Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Roll V8 from 4fe495ff9db8 to 92be807eabcc (2 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/4fe495ff9db8..92be807eabcc
2024-05-16 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.7.45
2024-05-16 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 DEPS (trusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I38af6af03314e91093b9a1dc5b6982d73c02a27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543683
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301789}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1715839127-25e1f613c02d022de41dec1eefee54296d07e5ed-384056a140a404afbb3e05e911973fc3130c36d4.profdata to chrome-mac-arm-main-1715839127-52e1e4f655770f4cc7b84b7f85dce1443586b6b4-384056a140a404afbb3e05e911973fc3130c36d4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib6d3f503cd2703699c71a61f3f2b373ce9c5864e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543541
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301788}
Roll Website from 1a0e901e0bd2 to 5acbcafd85a0 (2 revisions)
https://chromium.googlesource.com/website.git/+log/1a0e901e0bd2..5acbcafd85a0
2024-05-16 morg@google.com containers: Update documentation and fix links
2024-05-15 iby@chromium.org Getting Started: Don't link to internal sites
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dpranke@google.com
Change-Id: I9fa998b18a862f072cff4aac526213357321b485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543411
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301787}
Roll Media App from xlidS2cVpKlqrt2mv... to 0PJ4YF24hxSLkgBdd...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202405150800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/0PJ4YF24hxSLkgBddDmjHzKDfo21-MvdPIpsAg9TTZYC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,jomag@google.com,media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/227971302,b/291029007,b/291172884,b/291194936,b/307433827,b/307460044,b/315727478,b/319320100,b/335741382
Tbr: media-app@grotations.appspotmail.com
Change-Id: I4dfd1f525cad35a42958293bcad62a50c2d50ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542658
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301786}
Roll clank/internal/apps from f74ce6431e26 to 75116c76c01e (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/f74ce6431e26..75116c76c01e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ib981588b7497d1862743de7f81794354d44c984d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543686
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301785}
Revert "gardening: Remove telemetry_unittests from chromeos-betty-pi-arc-chrome"
This reverts commit 360a69ceace8995670ff6f501d5fdf87ae1ff8db.
Reason for revert: LKGM 15889.0.0 has passed so restoring the tests
to derisk the further breakage.
Original change's description:
> gardening: Remove telemetry_unittests from chromeos-betty-pi-arc-chrome
>
> Removing telemetry_unittests from chromeos-betty-pi-arc-chrome only
> temporarily to unblock LKGM.
>
> Bug: b:336609443
> Change-Id: Ie08bdbd6623d517dcceeae84ee1b0d371e46eed9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539139
> Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1301757}
Bug: b:336609443
Change-Id: Ib79590bea5100e54406e85e0f05a335f72a184d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541296
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301784}
Automated Commit: LKGM 15889.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8747911603390240241
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome-skylab
Change-Id: I9862bfcd87f9dcb6dfc837f376ddf0af672c4c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541674
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301783}
Roll Projector App from J08xVvebIcJaqDu4r... to xHlumul0yk4UtyXiy...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202405150100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/xHlumul0yk4UtyXiy3hjWWb0TIE7NVqYyIRghiMQHakC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: cros-projector-oncall@grotations.appspotmail.com
Change-Id: Ifbe05d064035313ff8c6a96c537632baf9d0ad8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542645
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301782}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1715831515-8de133c16f5131ad50a34aa96701bb78453cb3fb-a79016b824a0c1e0d8edd2afccb6773cd267d888.profdata to chrome-mac-arm-main-1715839127-25e1f613c02d022de41dec1eefee54296d07e5ed-384056a140a404afbb3e05e911973fc3130c36d4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Iad20bdbc6db27366b4a5b4cb2ed201543b18c5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542934
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301781}
Roll optimization-guide from 3a119dfcc524 to 8292d4380290
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/3a119dfcc524..8292d4380290
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I9741ac7cdfc6b8f12fdf0f8251610d00c117e953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543410
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301780}
Mark meta-viewport-link-headers-imagesrcset.html flaky
Bug: 339833760
Change-Id: I625c1d9eb62d1107ea974101b227fbe5e05e4fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539118
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301779}
JP SystemPK: Add a wrapper around ImeSharedLibrary UserData calls.
This wrapper will be used by the IMEUserDataService instead of directly
calling entry points. It'll allow us to mock the user data functions
better.
Deleting C_SerializedProto buffer logic from IMEUserDataService is now
handled by the UserDataCApiInterface.
BUG: b/328997024
Change-Id: I06ece5e7be698f1c9a3cc6cd866be8f95f5e543f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531340
Commit-Queue: jhtin <jhtin@chromium.org>
Reviewed-by: John Palmer <jopalmer@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301778}
Roll clank/internal/apps from 277d81edd38e to f74ce6431e26 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/277d81edd38e..f74ce6431e26
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I718b06f734b2aca2585485c039146eea984a6db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542678
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301777}
[clang-plugin] update test:raw_ptr_to_stack_allocated expectation.
Update the expectation according to the CL: crrev.com/c/5509323.
(the commit: eae01b710bdcf8771eae08ed83e9054f68e65f90)
Change-Id: If2cb1241976daffb2989485b6a90ce2736798024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538698
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301776}
[Chime] Add retries to PNS
When PNS fails to register itself, retry with exponential
backoff. However, if the failure is due to internet connection issues,
only retry when the connection has been restored.
Test: Added unittests and manually tested on DUT
Change-Id: I17a8aba82459b759b40611a07ec6db3ea2c2a332
Bug: b/323949082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529690
Commit-Queue: Alex Kingsborough <akingsb@google.com>
Reviewed-by: Juliet Lévesque <julietlevesque@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301775}
Use d3dx12.h in d3d12_helpers.cc
We have been using D3D12 video within //media/gpu/windows, and we can continue to leverage the helper functions and classes provided by d3dx12.h.
Change-Id: I377f30ae43a6a52a1b40c30511225bc76b2110b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541852
Commit-Queue: Zhibo Wang <zhibo1.wang@intel.com>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301774}
Prerender: Add NewTabPageTriggerForPrerender2 in field trial config
This CL re-introduce the group names of NewTabPageTriggerForPrerender2 in
the field trial config as
the following blocking issues are resolved
https://issues.chromium.org/u/1/issues/326509142
https://issues.chromium.org/u/1/issues/335369751
https://issues.chromium.org/u/1/issues/335517465
Bug: 40275094
Change-Id: If755a32952e6edcf366dad5627906144721923cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540992
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301773}
[Sync] Add test for incoming password group
Fixed: 40945611
Change-Id: Ifa274804cd4e111ec6e2a8585b3ed75ad7ac8ad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537897
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301772}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1715817086-62c8d4d7d8a0f859ec7c8e9f24d0fe96401d3233-800eb0868af83ada613f3c4dccccf5bf8ecc5eee.profdata to chrome-win64-main-1715828280-05b7774640def58a14644b3fd3e9cbefe9bef4c8-ed586f6db79beccf43d4404166175c53c0ad16e6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I455f244acaf79eae18801a8ca43f8da84af2fcbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538246
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301771}
[Compose] Add feature flag for displaying nudge at cursor
Bug: b/337980513
Change-Id: Id608e5e99b5b604999ff1aa56a608d0a314fda31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542684
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301770}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1715817086-be436a613cae00b0444eef36738108b7cdd135ec-800eb0868af83ada613f3c4dccccf5bf8ecc5eee.profdata to chrome-win32-main-1715828280-228fc63cada53a3ea6ddeeb3292d557044e5de83-ed586f6db79beccf43d4404166175c53c0ad16e6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I709bce10e07f32490582901a6bc53b652f8e5205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543522
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301769}
PA: Add a cautionary tale
The beloved idiom of function-static locals is widely enjoyed by
Chromies the world over. We find that under some circumstances it cannot
be used in PA. In fact, we find this out roughly every two years.
Add an in-repository cautionary tale to hopefully make this particular
footgun a bit more obvious.
Change-Id: I8d41aaf43cca8cf92c88927f591c7ea639f9ba3b
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539115
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301768}
Move browser actions to c/b/ui
Cleanup browser actions to remove views dependencies and moved it from
c/b/ui/views to c/b/ui. Introduced some helper functions to companion
and history cluster side panels. Having browser actions directly as a
member instead of being added to user data by the browser window.
Change-Id: Idd6cc891f3478ec55876107b59eda3dcb572fd1d
Low-Coverage-Reason: LARGE_SCALE_REFACTOR
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530998
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301767}
boca: Add resource ID for google3 generated resources.
BUG=b:336881992
TEST=Not needed
Change-Id: I46e3f192f1eb09e2ae473cd5ee69c6480df32174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542695
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: April Zhou <aprilzhou@google.com>
Cr-Commit-Position: refs/heads/main@{#1301766}
Update group names in CrOSLateBootLowMemorySignaling
Bug: b/339740654
Change-Id: Id9dc113a10636c6398ed440abc7f977c1a0fa4ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541491
Commit-Queue: Charles Dick <cwd@google.com>
Reviewed-by: Charles Dick <cwd@google.com>
Commit-Queue: Shin Kawamura <kawasin@google.com>
Reviewed-by: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301765}
Stop using ThreadSafeRefCounted for BackgroundResponseProcessor
BackgroundResponseProcessor class is currently ThreadSafeRefCounted. And
BackgroundResourceScriptStreamer's BackgroundProcessor lives in the
main thread, the background thread of loading and the worker thread of
JS parsing. This complicates lifetime management of the class. Also
we can't use WeakPtrFactory for the class (See crrev.com/c/5514715).
To solve this problem, this CL introduce a new factory class named
BackgroundResponseProcessorFactory. After this cl, the factory class
is created in the main thread, and passed to the background thread of
loading. And its Build() method will be called in the background thread
to create a BackgroundResponseProcessor. The BackgroundResponseProcessor
will live only in the background thread.
Currently BackgroundResourceScriptStreamer::FinalizeOnMainThread() is
called to take the result from the BackgroundResponseProcessor. But
after this CL, the result is passed from the background thread to the
main thread using CrossThreadWeakHandle of
BackgroundResourceScriptStreamer.
This CL also removes BackgroundResponseProcessor::Cancel() method,
because the owner of BackgroundResponseProcessor can cancel just by
deleting the BackgroundResponseProcessor.
The new relationship diagram:
https://docs.google.com/drawings/d/1W9F8SPkA9fxQYuJRHCKH5C9kbrQDP30qI-qOLIGIaok/edit
Bug: 40244488
Change-Id: I947e3e193ce6431656f103f0ac7dddb57c4b1e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528481
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301764}
Roll optimization-guide from d9e056fb453e to 3a119dfcc524
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/d9e056fb453e..3a119dfcc524
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I4c8617ae7c28a18d04969e530ca642574a5a08b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543606
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301763}
[IntersectionObservation] Fix needs_occlusion_tracking bookkeeping
This fixes three related bugs in occlusion tracking:
1. When an IntersectionObserver using trackVisibility is created in an
OOPIF, there is some latency in notifying the parent renderer that
occlusion tracking is required for the iframe. During that interval,
the parent renderer might send a 'guaranteed not occluded' message to
the child, causing the IntersectionObserver to report a false
positive. With this change, we will never tell an OOPIF that it's
"guaranteed not occluded" if the OOPIF hasn't requested occlusion
information. This is fixed in frame_view.cc.
2. When an OOPIF runs LocalFrameView::RunIntersectionObserverSteps,
it might get a transient `false` value when recomputing
needs_occlusion_tracking, due to an early return from
UpdateViewportIntersectionsForSubtree (which has a couple of
early-return edge cases). When that happens, we should *not* relay
the `false` value back to the parent process, because it can create
a temporary gap in occlusion reporting from the parent. We should
instead preserve the previous value until it can be successfully
recomputed on a subsequent BeginMainFrame. This is fixed in
local_frame_view.cc.
2. For OOPIF's, needs_occlusion_tracking is stored in two places:
on RemoteFrameOwner::needs_occlusion_tracking_ in the iframe process,
and in RemoteFrameView::needs_occlusion_tracking_ in the parent
process. When the first one changes in the iframe process, it IPC's
to the parent process to synchronize the second one. To keep them
consistent, there should be no other point of entry into
RemoteFrameView::SetNeedsOcclusionTracking. Currently, that method is
also called from RemoteFrameView::Dispose, but that call is unnecessary
and it can cause the two values to get out of sync. This is fixed in
remote_frame_view.cc.
Bug: chromium:333708039
Change-Id: Id1dd08eefb5aa201651b2c6950ea61f3b4a081a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540331
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301762}
Roll Depot Tools from 7f95b88c669f to 274689c4a551 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f95b88c669f..274689c4a551
2024-05-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC chops-source-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
Change-Id: I23f4d6c707d72035ec3a30e4d001ae374fd7b610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543018
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301761}
gardening: Disable ui.ChromCrashEarly.* on reven
ui.ChromeCrashEarly.loose and ui.ChromeCrashEarly.strict is blocking
LKGM with the same reason we had 2 weeks ago, so disabling the tests
again until the proper fix will land.
Bug: b:336585651
Change-Id: Ia32083d2afe4f9932b015246681a958166674e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541557
Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301760}
Roll Infra from d44275688895 to 0ff3a23429ed
https://chromium.googlesource.com/infra/infra.git/+log/d44275688895..0ff3a23429ed
2024-05-16 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from e38887b957c9 to f4ced2a3fa28 (1 revision)
2024-05-16 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/config from aa655bf60238 to 2ea79eb4f9d0 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-chromium
Please CC iannucci@google.com,luci-eng@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: iannucci@google.com
Change-Id: I83d0296b2c5a4393fb7f43c5004f7d1527999463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543526
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301759}
Revert "[WebDriver BiDi] Don't try to attach Target when handling BiDi commands"
This reverts commit a31094aaaddee47b86fcd7f4856cf72e20cd7726.
Reason for revert: Appears to have caused user_prompt_opened.py to start failing on Linux:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/120303/overview
Original change's description:
> [WebDriver BiDi] Don't try to attach Target when handling BiDi commands
>
> Whenever the `browsingContext.close` BiDi command is called,
> ChromeDriver tries to update its internal map of targets.
> But if a user prompt is open that may make CDP commands hang indefinitely
> we should let BiDi handle them as it has already established
> connection to these targets
>
> Bug: chromedriver:4758
> Validate-Test-Flakiness: skip
> Change-Id: Id1d7ed7f85dc1af173dab1d71dd664532ea43f49
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522393
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Maksim Sadym <sadym@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1301241}
Bug: chromedriver:4758
Change-Id: I425a627ca23842720f6ce94413469e74ebb4b70c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539818
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Owners-Override: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301758}
gardening: Remove telemetry_unittests from chromeos-betty-pi-arc-chrome
Removing telemetry_unittests from chromeos-betty-pi-arc-chrome only
temporarily to unblock LKGM.
Bug: b:336609443
Change-Id: Ie08bdbd6623d517dcceeae84ee1b0d371e46eed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539139
Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301757}
[MiraclePtr] Harden the reference count overflow check
Reserves the most significant bit of the reference count to prevent
races with overflow detection.
Bug: 340122160
Change-Id: I20740d384c16d04db2a0e9c8f65100f6aa4e1f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538010
Auto-Submit: Sergei Glazunov <glazunov@google.com>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301756}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1715824643-8bcace152ba60bf9cf387eb4f833e25ef41bce72-7b1c72a2a3ab307d588608c64948e8262ecfe824.profdata to chrome-mac-arm-main-1715831515-8de133c16f5131ad50a34aa96701bb78453cb3fb-a79016b824a0c1e0d8edd2afccb6773cd267d888.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Icd1684bda0d6782daf9f789bb5c45f82524c1746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543604
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301755}
Roll V8 from e31c9d0f8e51 to 4fe495ff9db8 (6 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/e31c9d0f8e51..4fe495ff9db8
2024-05-16 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.7.44
2024-05-16 mfarazma@redhat.com PPC/s390: [deoptimizer][wasm] Support Simd128 values
2024-05-15 adamk@chromium.org [api] Remove duplicate ModifyCodeGenerationFromStringsCallback field
2024-05-15 rezvan@chromium.org [explicit-resource-management] Change variable names format
2024-05-15 rezvan@chromium.org [explicit-resource-management] Add move and disposed getter
2024-05-15 rezvan@chromium.org [explicit-resource-management] Add adopt and defer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I2b894baef7276a76f1769359678331e63f1294f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538244
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301754}
Close orphan workers.
If the execution context is destroyed before running the script, it
should be an orphan worker. We do not need to execute the script.
Fixed: 340142506
Change-Id: I18a21da4a3f777ea33c472e2e22c16e3afa233ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541199
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301753}
[lensoverlay] Add Chromnient to the field trial testing config.
Previously, the feature was listed in the fishfood config but it will
now match the name of the study and therefore avoid warnings on Finch
CLS.
Bug: b:328296127
Change-Id: I439a5e9ff58f4050706d33afb8bd6d535b92e33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5537938
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301752}
[RasterInducingScroll] Plumb compositor scroll offsets to DrawScrollingContentsOp
When creating raster tasks, the tile manager gets a snapshot of current scroll offsets of raster inducing scrolls in the layer (through PictureLayerTilingClient implemented by PictureLayerImpl). During
rasterization, the scroll offsets are passed to the raster source.
cc::DrawScrollContentsOp applies the scroll offset, select paint ops
from the display item list with RTree by the visible viewport (which
is the current device clip of the SkCanvas) and replay the selected
paint ops.
In OOP rasterization, similar to the above but the selected paint
ops are serialized as ordinary paint ops.
Bug: 715106
Change-Id: I351ed48f632f6d5a2644cc08bca596081b318c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4836973
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301751}
[text-box-trim] Support vertical flow
In doing this, this patch adds the `FontBaseline` variations
of `Alphabetic()`, `CapHeight()`, and `XHeight()` in the
`FontMetrics` class.
Also, the rounding methods in `AdjustEdges()` were different
from what `FontMetrics::FixedAscent()` does. This patch adds
`Fixed` variants to `FontMetrics` to make reviewing the
consistency easier.
All changes are under a currently disabled runtime flag.
Bug: 40254880
Change-Id: I470f1df976ff210ee7c3cdb336b73f44a59909d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539097
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301750}
Isolate OmniboxSuggestionsDropdown constructor params to setters.
This change paves the way to experiment with async view inflation,
allowing us to further configure the Omnibox with the XML (which,
when inflated asynchronously, shouldn't really matter). The change
binds Asynchronous inflation to a dedicated feature flag.
Bug: 40253396
Change-Id: I642caa02c4ca8ffd0ad306ec327ef134727e6f76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538578
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#1301749}
[wptrunner] Refactor manifest retrieval in `WPTResultsProcessor`
`WPTResultsProcessor` has several callsites (with another one to be
added) that switch on whether a test is external or internal when
deciding which manifest to use. These can be streamlined by enriching
`PathFinder.is_wpt_internal_path(...)` to return which WPT directory
specifically the path falls under (i.e., a tristate "external/wpt",
"wpt_internal", or `None` for non-WPTs).
No functional change.
Bug: None
Change-Id: Icb053619e6e776b97c27b403bd77cb97f57ea55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540374
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1301748}
Disable RenderWidgetHostHiddenCheck on Lacros
This check has been hit on lacros. Disable it while we investigate the
root cause.
Bug: 338354134
Change-Id: I24572e85581bf2217855c7ee8f9c322a62f6c974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538695
Auto-Submit: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301747}
Roll Chromium Variations from 88edede41e0c to 83915e39be4e (49 revisions)
https://chromium.googlesource.com/chromium-variations.git/+log/88edede41e0c..83915e39be4e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-variations-chromium
Please CC chrome-metrics-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: chrome-metrics-team@google.com
Change-Id: I1d4c9967c7299142991e09171d5dfe4fa4a5bc35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543013
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1301746}
build: fix unused var error
This is fix for https://crbug.com/41489832#comment26
Bug: 41489832
Change-Id: I56e661a64884c4e0ba05e3b0768c187cfbeaedd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540820
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301745}
Remove dependency on experimental document policies in tests
There are several internal and external tests which rely on experimental
document policy features to demonstrate the operation of document policy
itself. This CL updates these tests to use more well-standardized
features instead.
Bug: 340920459
Change-Id: I8bccbb6f86ffae4dfcd086bf2947a0adac5eb107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539454
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301744}
[CrOS Cellular] Populate shouldDisallowApnModification in OOBE dialog
Update <internet-detail-dialog> to populate <apn-list>'s
shouldDisallowApnModification property in order to disable APN edit
actions when AllowApnModification is false.
Bug: b:333100319
Test: On device, *InternetDetailDialog*
Change-Id: I03272fce1dc1a5f905efb06c83e92052caab42a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540787
Auto-Submit: Gordon Seto <gordonseto@google.com>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301743}
[Ash] Move //chrome/browser/ash/telemetry_extension to //chromeos
This directory did not have any //chrome dependencies, so it did not
need to be in //chrome. Instead, move it to //chromeos/ash/components,
per guidance in go/ash-architecture-policies.
This CL also removes no-longer-relevant DEPS files.
Bug: b:335294026
Change-Id: I20f6938e8f51ac6e36e6d596526d5e6c301ae1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543222
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ethan Cheng <yycheng@google.com>
Cr-Commit-Position: refs/heads/main@{#1301742}
Jp SystemPK: Add histograms for japanese settings.
Bug: b/339420220
Change-Id: I0153e32436465ce2a4be1ad1fc1056b45f33b7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528647
Commit-Queue: jhtin <jhtin@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301741}
Refactor: Add an enum to represent the different Picker modes.
This is needed to decide what categories are available and what
actions to apply for each type of result.
Bug: b/339526117
Change-Id: I8f4bbf912f78e85e77e0193b3573c0a197d4f6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528844
Reviewed-by: Jing Wang <jiwan@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301740}