Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
[autofill][clank] Refactor AutofillSaveCardBottomSheetContent for MVC
Refactor AutofillSaveCardBottomSheetContent to remove view specific
code. Before the refactor, the content file created and maintained the
view for the save card bottom sheet but this is replaced in this CL
with the new properties, view, and view binder files created in the
following CL: https://crrev.com/c/5447088.
Update AutofillSaveCardBottomSheetCoordinator to create and use
the new AutofillSaveCardBottomSheetProperties and
AutofillSaveCardBottomSheetView as the model and view. Previously, as
the content file handled the creation of the view, the UI Info object
was passed to the content object to set up. With the new properties,
view, and view binder files, the coordinator needs to initialize their
values first.
Updated the content test to remove any tests related to the view. They
are now being covered by the view binder test as well as the
coordinator test for the initialization of the property model.
Design doc on the refactor: http://go/loading_and_confirmation_save_card_and_vcn_enrollment#bookmark=id.m5ovk748eysk
Bug: 1499264,b/333935391
Change-Id: Icc37e8afe22d6d0d0d47c4bc25887e010511fc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479991
Reviewed-by: Timofey Chudakov <tchudakov@google.com>
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Commit-Queue: Darwin Yang <darwinyang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294850}
Roll FreeType from 1168b1b5b077 to 13da9042676e (5 revisions)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1168b1b5b077..13da9042676e
2024-05-01 apodtele@gmail.com * src/sfnt/sfwoff2.c (compute_ULong_sum): Clean up.
2024-04-30 apodtele@gmail.com * docs/CHANGES: Updated.
2024-04-30 apodtele@gmail.com * src/cache/ftccache.c (FTC_Cache_RemoveFaceID): Remove nodes instantly.
2024-04-29 apodtele@gmail.com [cache] Remove unused `node_reset`.
2024-04-29 apodtele@gmail.com * src/cache/ftcmru.c (FTC_MruList_New): Do not reset nodes.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.15-blink-rel;luci.chromium.try:win10.20h2-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I19d30f45fa81fbc51bc05b3122d00d553367b6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502828
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294849}
[ios][pwm] Upon filling,only update field manager if it happened
Currently, upon filling and success, both the password and
username fields are updated in the FieldDataManager even if filling
didn't happen in reality, which can make make the field data in the
manager not reflecting what is actually in the renderer, hence
inaccurate.
Success doesn't mean fill where under certain conditions, filling the
field is skipped but still gives success. Deciding whether or not this
is okay is beyond the scope of this CL.
For example, filling the username will be skipped while still returning
success if the username field was set to read only, even if the
fill data specifies to fill the username.
Change-Id: Id6606b9950bdf2181c8b96d3a207ae8ac79e2c12
Bug: 337637910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494354
Reviewed-by: Ernesto Izquierdo Clua <eic@google.com>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/main@{#1294848}
Use a non-pinned notification for remote support confirmation.
Pinned notifications can only have a single action button, which for
this notification is "Decline". Unpinned notifications can have two.
I've confirmed that this fixes the bug in a ChromeOS-on-Linux build.
Bug: 327483680
Change-Id: I2c2ccf1ce4db99bc4197593655c84a5be1e96a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502598
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294847}
WebUI: Enforce querySelector<Type>() pattern via ESLint, part 7 (last)
In this part, amending the existing checks to also catch such cases.
All violations have been fixed in precursor CLs.
A common misuse of querySelector/querySelectorAll is to use a type cast,
like
this.shadowRoot.querySelector(...) as Type
instead of leveraging the type parameter, like
this.shadowRoot.querySelector<Type>(...)
The previously added ESLint checks miss cases where a "not null"
typecast exists, like
this.shadowRoot.querySelector(...)! as Type
Fixed: 1521107
Change-Id: I0bebe973d3467b92c53525ac4bc0337814481bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502593
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294846}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1714543047-922ad6bac4595f5c66dfbaf0f5d655961f63ce79-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata to chrome-win-arm64-main-1714564570-598bda8c551fe93dc0ec254d471fc60f37ab4576-766f3086cd2743390ca1c5215a0910ddcae214e5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I5e6326012065e41feca4ba6efebad10486dfe4cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505024
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294845}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1714521396-e683e862d943839b6979b6b941e4ce159eec4561-858d14b7f68029a3eccf1ee9e27b01114c2c0db0.profdata to chrome-chromeos-amd64-generic-main-1714564570-fb9dc85912d1d23f92a2a1a620c59b1e0cd380ee-766f3086cd2743390ca1c5215a0910ddcae214e5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I935aea89f2d6951d5a15cf20258fd81adde5f7b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505125
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294844}
Roll clank/internal/apps from 425b1c72b8a8 to a09b722852ae (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/425b1c72b8a8..a09b722852ae
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC abhijithnair@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abhijithnair@google.com
No-Try: true
Change-Id: I4335f8e500c5be941e0f6a2adfedb3b9328176cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505023
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294843}
Add GlobalFeatures to BrowserProcess
Akin to BrowserWindowFeatures and TabFeatures, GlobalFeatures can be
used as the owner of globally-scoped feature controllers.
Bug: 338030740
Change-Id: Ie3acdb49f9a5f7fa386b46c3962d0b7dbfed8cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502115
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Mickey Burks <mickeyburks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294842}
Revert "Add tests for voice and language prefs"
This reverts commit eaf191b2e8d1ee194f2cc8a5f1c1cf87721a3a05.
Reason for revert: Newly added test is failing right away on bots.
See https://ci.chromium.org/ui/p/chrome/builders/ci/linux-lacros-chrome/1279/overview for the first failures
Original change's description:
> Add tests for voice and language prefs
>
> Fixed: 337910273
> Change-Id: I674a87b63e9823bdee136674da82464daaca928c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503425
> Auto-Submit: Kristi Saney <kristislee@google.com>
> Reviewed-by: Lauren Winston <lwinston@google.com>
> Commit-Queue: Lauren Winston <lwinston@google.com>
> Cr-Commit-Position: refs/heads/main@{#1294761}
Change-Id: Idaf60fdc30ca4624b6233caedd1838ae087d9301
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502655
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294841}
Revert "picker: display at most 2dp for math results"
This reverts commit 3e9499d6167099d958601243d1fb10e7792883f8.
Reason for revert: Crashes on MSAN builds: See https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/42903/overview for the first crash.
Original change's description:
> picker: display at most 2dp for math results
>
> Bug: b:337112140
> Change-Id: I763e99bb6a8a05b42e17e4c0cda221b29b937a1c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505069
> Reviewed-by: Darren Shen <shend@chromium.org>
> Commit-Queue: Jing Wang <jiwan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1294772}
Bug: b:337112140
Change-Id: I42729cbf0c27ccb582fa02cc26781ed3ba859abe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504830
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294840}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714543047-6bf436b5e88be26d40eefdbb3b4f5b50e1cd43c7-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata to chrome-win32-main-1714553931-f821fe1cc5ed7f9a435ba0b5a0d2eb70e669e66f-1e3eda9848f805762eaaa0258d1d2531d0c29db1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ieda9a15d29dbb6e7c357c442c2df039dd514c5d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504996
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294839}
Roll ANGLE from bb6a5724e609 to 53811e86cc33 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/bb6a5724e609..53811e86cc33
2024-05-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 83c70f11490d to bc4f0a08ba8d (625 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I2a83718b704a9e58bb76e6e17c5231e7713b1ecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505136
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294838}
Simplify HeapProfilerController [4/3]
Simplifies the callbacks that quit the RunLoop in the unit test.
Different test cases expect different functions to be called during
the test, and there's a confusing chain of callbacks that waits until
the last function is called before calling the loop's QuitClosure.
Replaces this with a BarrierClosure: each function that's expected
during the test calls the BarrierClosure once, and the BarrierClosure
invokes the QuitClosure once all of them are done. If one of the
expected functions isn't called, the test will time out, and if an
unexpected function is called, the test will fail.
Also simplifies the semantics of `on_first_snapshot_callback`. It's
now called exactly when HeapProfilerController::TakeSnapshot() is
called.
This will make it easier for a followup to add tests that communicate
over mojo between fake "browser" and "child" processes, that will
need to wait for more callbacks before calling the QuitClosure.
Also also updates the tests to expect
HeapProfilerController::IsEnabled() to return true when profiling is
enabled by the test params, instead of when the params expect a
sample to be collected. By coincidence all the updated tests expect a
sample exactly when profiling is enabled so this doesn't change any
behaviour, but it prepares for a followup that adds tests with
profiling enabled that don't expect a sample.
R=etienneb
Bug: 40840943
Change-Id: Iee9b01b6117695a3d436ad24a1684e33dcf559bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503035
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294837}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1714543047-ab0765ecb0f286902197c72edecad48ed776e6b6-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata to chrome-android32-main-1714564570-38c0469c02a81002d3a97c4a286f9d3f45f8dd4c-766f3086cd2743390ca1c5215a0910ddcae214e5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I066f9e514116c260cc1b7abff91a2bda2f13490c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505426
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294836}
Move ValueResultFromWKResult to ios/web/public
This function can be outside of ios/web to convert JS responses into
base::Value types.
Bug: None
Change-Id: I2c30c1beed7b90b15e88e4753f9c694f28471c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502912
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294835}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1714556682-295ad63e807748d6e6e38999cccf6f29eb8aef22-d23a66f24c49d1a578da29032751b2d670ea0180.profdata to chrome-mac-arm-main-1714564570-8d33515c004ec0c6432daf750e8d5855b1db9d07-766f3086cd2743390ca1c5215a0910ddcae214e5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I240085a5238f49392bd9b0cc518c78757d11dca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505000
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294834}
metrics: de-flake some NavigationTiming tests
These tests were using the real clock and expecting navigation events to
happen within certain time thresholds, causing flake when run on slow
hosts or heavily loaded bots, especially under sanitizers. Instead, use
a mock clock.
Fixed: 327150423
Change-Id: I267f751948fb5c3c315f4a9668139ebd1ccd675c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503097
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Auto-Submit: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294833}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1714543047-98dda6cf3baff2e81a86e8637a5e74e5a385cc7d-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata to chrome-win64-main-1714553931-c5c9dc8393534975f16d83674b269fea399d643a-1e3eda9848f805762eaaa0258d1d2531d0c29db1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I37151b0a030c1504cefa72643f18e78eacc770d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504595
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294832}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1714528593-79f278ddfa737eb64960c7ac14e3fbc399fa53e2-68f81fc70c134a8c26357642483f6947a4bed440.profdata to chrome-android64-main-1714549974-9dd7fb531eeae2d2f0f105e2535eb0f5373f6a26-bc4f0a08ba8d4453fc183d3ef4d59889a3b1cdde.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I148d153e9b0a9aa2593b33179b0bab7ab72e7f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504997
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294831}
Roll devtools-internal from 53d1a01950ba to e70702b5f670 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/53d1a01950ba..e70702b5f670
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54f63864043c10cb07c7598d77fde3a3f4e43d7c..bf132c052eebd268de51be2bb346febcff4bf490
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I911a2dd7f2ca4a5eb3d7de315d383e4f4370d5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504596
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294830}
Roll Skia from bfbd738fb97b to 341ee60bc0e4 (1 revision)
https://skia.googlesource.com/skia.git/+log/bfbd738fb97b..341ee60bc0e4
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9384550810a5 to ae1ce5ca5a1e (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: kjlubick@google.com
Change-Id: Ib4aeb4df252f8e44d233c302262889c894361449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505331
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294829}
Stop using SetHeaderPolicy in CreateFromParsedPolicy.
This also introduces a struct to carry the final result of parsing allowlist and reporting endpoints in the permissions policy header and we pass that struct to the PermissionsPolicy constructor.
This also make origin_ and inherited_policies_ const.
This leaves several places still passing {} and modifying with setters later.
Change-Id: Ia501de3b66d09e296fc35e7259d4200c5fed5c78
Bug: 338183241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475204
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294828}
Roll Projector App from VDnK2l85qHEVxJXLt... to tqXzk2cIvOQGQ2NBd...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202405010100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/tqXzk2cIvOQGQ2NBdPnAlSYroadx-PXO-gqKZUMZQrkC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/329426516,b/329429058
Tbr: cros-projector-oncall@grotations.appspotmail.com
Change-Id: Ia01a5b96505113ebcdd0b6ae59369850c28f6b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505133
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294827}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1714549974-59d9a9da8813cb9003fd41429e51ba63bc194b16-bc4f0a08ba8d4453fc183d3ef4d59889a3b1cdde.profdata to chrome-mac-arm-main-1714556682-295ad63e807748d6e6e38999cccf6f29eb8aef22-d23a66f24c49d1a578da29032751b2d670ea0180.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8bc985f68fd45f26b4d83aaa59cd42791aec8d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505318
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294826}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714532302-93222ff2dd88cf41cdeee1333db3634f971827ce-b1ee301602b650f10de8288ae20e73ea523e9889.profdata to chrome-win32-main-1714543047-6bf436b5e88be26d40eefdbb3b4f5b50e1cd43c7-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If1b18174bdf7580cd6add1cc7f201e25cabcc63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504993
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294825}
Roll Dawn from 275e078952a5 to 1488c9c94dea (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/275e078952a5..1488c9c94dea
2024-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e49b941fefd5 to bb6a5724e609 (5 revisions)
2024-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from dbb9c9757a73 to e7b78ff9c99c (4 revisions)
2024-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 09d0317bc33e to 9384550810a5 (10 revisions)
2024-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 2c87882a7bac to 765b75b4c081 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: None
Tbr: enga@google.com
Include-Ci-Only-Tests: true
Change-Id: I5dec7815cf1d9a7e854a1b9aba9ef062eb402768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502603
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294824}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1714532302-1a6b7b165c4e54730a2e72b5e49c056d19288671-b1ee301602b650f10de8288ae20e73ea523e9889.profdata to chrome-win64-main-1714543047-98dda6cf3baff2e81a86e8637a5e74e5a385cc7d-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I85d03b0c718466863601d87b49732fcc46256698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505267
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294823}
Extend V8 benchmarking extension with cpu marks
Some profiling tools can add triggers based on execution reaching a
certain address. For example ETM tracing can be started and stopped when
execution reaches a given address. This is very useful in keeping the
size of these traces small.
This cl adds two JS functions for this purpose. You also have access to
the runtime virtual addresses of each of them so that the profiler can
be configured accordingly.
Bug: b/300261556
Change-Id: I8f35fee12ea8e765ed3715898619ced3a42d20a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494252
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Carlos Caballero Grolimund <carlscab@google.com>
Cr-Commit-Position: refs/heads/main@{#1294822}
Roll ios_internal from a1c523788e11 to 6329fb126747
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/a1c523788e11..6329fb126747
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,hiramahmood@google.com,vincb@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I0510595d6a2d41fe09050ec4d61f7e53ebb28909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505120
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294821}
RubyLB: Fix annotation inline positions with bidi reordering
LogicalRubyColumn::start_index was stale after bidi reordering.
Bug: 324111880
Change-Id: I585018d2f67c5d2c1a2b906720d021771ce4bc00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490884
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294820}
Roll devtools-internal from f4a271377c1a to 53d1a01950ba (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/f4a271377c1a..53d1a01950ba
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9882851278e670464a461cbf50e68fe8954b1ef..54f63864043c10cb07c7598d77fde3a3f4e43d7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: Ied39b4804d5b25014aca512a3b87c81c4f0de214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505315
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294819}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1714543047-0aee65d2635c9856525fcf46e501d186e86600ce-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata to chrome-mac-arm-main-1714549974-59d9a9da8813cb9003fd41429e51ba63bc194b16-bc4f0a08ba8d4453fc183d3ef4d59889a3b1cdde.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Iad5b917a1c5c82a0700068c58a03b10dc9a6b131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505370
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294818}
[siso] Add -config=clang-tot flag to disable remote clang actions
Clang ToT builders don't use remote execution because they can't use
them for missing reclient cfgs and docker container images.
This CL adds `clang-tot` Siso config which disable clang c/c++ compiles
and Rust compiles to keep the behaviors.
Other non-clang remote actions are still executed on RBE. e.g. mojom,
typescript etc
Bug: b/315393741
Change-Id: I44d678b59c4fa01fabe3795d4796ffd162fcdd3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504611
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1294817}
Remove dependency on base::CPU when dealing with MTE or BTI
Various security features depend on detecting support by the cpu.
For speed, those checks use base::CPU::GetInstanceNoAllocation(),
making the feature attackable by modifying the data stored in this
instance.
To mitigate against this kind of attacks, this CL uses the fact
that cpu support is constant through a processes' runtime and
implements a solution using the runtime linker to resolve the
correct functions by using ifuncs. The runtime linker will ensure the
ifuncs are protected from modifications after program start, i.e. when
linking with "-z relo".
Bug: 1521272
Change-Id: I013cecf1a55d03cdd9503ae8c217b842e323a3b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453915
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Andre Kempe <andre.kempe@arm.com>
Cr-Commit-Position: refs/heads/main@{#1294816}
RubyLB: Enable the flag in Blink tests
"ruby-lb" virtual test suite is removed.
Bug: 324111880
Change-Id: I6d96248bdf6170729576fb5f37006f2834b47d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485846
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294815}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1714521396-703f79658c983bae540d4d305c0c60166ebda9d4-858d14b7f68029a3eccf1ee9e27b01114c2c0db0.profdata to chrome-linux-main-1714543047-b0430e3da2a07ea28ec7d24c287d59e047786649-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I3615b2739ca291bdbf7843ae5c068833f2901835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502608
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294814}
Add metrics to record the router rule condition depth and width.
Before deciding the limitations, let me record the maximum size to
understand how people use this.
Bug: 338085660, 40284745
Change-Id: I15bdd0ac587f107c65dfff96b509b8b593633e4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505209
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294813}
Roll optimization-guide from 4acabe3ee49f to 691a0af78785
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/4acabe3ee49f..691a0af78785
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I9c6a073b4274b5294bee105cbce3eead2201a0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505369
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294812}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1714521396-d1b4f21647650fb870fdc525ff3d7019f51a9656-858d14b7f68029a3eccf1ee9e27b01114c2c0db0.profdata to chrome-win32-main-1714532302-93222ff2dd88cf41cdeee1333db3634f971827ce-b1ee301602b650f10de8288ae20e73ea523e9889.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Icee2bb38b0593dfedf139df076b5a22abd900bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504407
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294811}
Use hasCondition() or hasSource() to confirm their existence
If the rule without condition or source is used, it causes the renderer
crash because the IDL expect condition() and source() is used only if
they are set.
Change-Id: I34b8f76b1cf4f245b7b096db120176134d72b6c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504213
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294810}
siso: add obj/chrome/test/browser_tests/file_tasks_browsertest.o to exit137_list
https://ci.chromium.org/ui/p/chromium/builders/build/linux-chromeos-build-perf-siso/1763/overview
[195614/196719] CXX obj/chrome/test/browser_tests/file_tasks_browsertest.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/test/browser_tests/file...(too long)
remote-exec 6f717520d7cf08df72c8971a97033ace98b3ca5f009a47e2c56c910dd4565967/355 failed no-fallback: exit=137
error: 1 steps failed
Bug: b/289968566
Change-Id: Ied756454874418ad89b07b1b044644c4861dd1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504352
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1294809}
[office] Set the priority of notifications to SYSTEM_PRIORITY
Since http://crrev.com/c/4938755 the never_timeout boolean is ignored
for notifications with priority lower than SYSTEM_PRIORITY. These
notifications cannot time out so set their priority to SYSTEM_PRIORITY.
Bug: b/337985250
Change-Id: Ibd509b75715d44a9a9038c789d71b14eec61b727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504791
Reviewed-by: Alexander Bolodurin <alexbn@chromium.org>
Commit-Queue: Cassy Chun-Crogan <cassycc@google.com>
Cr-Commit-Position: refs/heads/main@{#1294808}
Roll devtools-internal from 243661700ce5 to f4a271377c1a (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/243661700ce5..f4a271377c1a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I7e32d3e59f5575556273201b043b4affe6457081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502605
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294807}
[cleanup] Remove ComputedStyle::ShouldUseTextIndent
Unnecessary complexity - remove.
Change-Id: I0039360cff41a32bd1e8f31a0eb2d7414f0424b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503809
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294806}
Remove stale pixel expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite pixel --jobs 4
Affected bugs for CL description:
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 329235191
Change-Id: Ieae1ebbe2e5f554da366c63eb32617e10c054412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504986
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294805}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1714521396-7014e26b5575a455da37d04cfa1d0fa96e88d198-858d14b7f68029a3eccf1ee9e27b01114c2c0db0.profdata to chrome-win-arm64-main-1714543047-922ad6bac4595f5c66dfbaf0f5d655961f63ce79-508f1f09dab21aab3e96fd66e84b35ed620e7cd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6b87abcb35bbd1c73037329603cedf0cfe1996cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505312
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294804}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1714521396-4e5d2323593b27080be932ab3ec6211c3752d9a9-858d14b7f68029a3eccf1ee9e27b01114c2c0db0.profdata to chrome-win64-main-1714532302-1a6b7b165c4e54730a2e72b5e49c056d19288671-b1ee301602b650f10de8288ae20e73ea523e9889.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I530b5c17c45a307968aa663987af7927f918038e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505110
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294803}
[FilesUMA] Extend Drive.PushNotificationRegistered
Bug: b:336308192
Change-Id: I05f950c63fe5f2f7976bb31be04942942ed2b3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5500015
Commit-Queue: Wenbo Jie <wenbojie@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294802}
diagnostics: Convert network_info_test to TS
Bug: b/245336251
Change-Id: Ib1ebc5ab74d734f1496452959cfd549ea6a6840f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457014
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294801}