Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
focus-mode: ensure music pauses for the ending moment
This CL ensures that when the track in the media player changes (either
by user or automatically) that the focus mode sounds controller is still
connected to the correct media controller. The error previously was that
it assumed audio focus wasn't lost when switching tracks, meaning that
we would always be bound to the initial media controller. This resulted
in all play/pause actions to be sent to the wrong controller.
Bug: 380173752, 366581937
Test: added FocusModeBrowserTest.PauseNextTrackDuringEndingMoment
Change-Id: I9175ffa422ac39c4e473d1d14adaf2233d6af6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427641
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Richard Chui <richui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443026}
[tab suggestions] Add overlap detection
Stop similar suggestions from triggering
NO_IFTTT=new check added
Bug: 397221723
Change-Id: Iaea2ae332f9258ddd82eb6b0639d01af7cb4e932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434577
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443025}
[client-certs] Remove flaky connectivity check in E2E test
The check was intended to validate network preconditions (e.g., DNS,
firewalls), but it seems to cause more trouble that it's worth [0]. Just
go straight into the test.
[0]: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket/8720808011059892913/+/u/find_failed_tests__2_/connector.client_certs.client_certs_test.ClientCertsTest/test.py_output
Bug: 398278180, 327797500
Change-Id: I2bc234b701ad791d3e6a06b994ec5497282eab42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6344931
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Xiang Ji <jxiang@google.com>
Cr-Commit-Position: refs/heads/main@{#1443024}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1743789549-902c7b47478fcdc3a60a5c578fb74fe4da2d77b9-dcba6bc357860cbbb3cd2955b94646c769f75e92.profdata to chrome-win-arm64-main-1743810139-d41856c68051ccd770e74d71882411904a51c6d8-101be815a55131d39aecbbc80a0dc46b6b2dd61e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I065f76435024b4f614992fe853aa7bcf329e0a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435343
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443023}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1743789549-b7df196dde78194ddcccd69d4f908cd1715e7dd9-dcba6bc357860cbbb3cd2955b94646c769f75e92.profdata to chrome-win32-main-1743800210-45fdcd98b78fb07571b288901eb25244ae1430ea-031bcbf4a407a26f5a676b05b98c0f9db479a16a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ic2ed3fede5743b629f2e6dd6f47181819386f7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434622
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443022}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1743789549-b9345a8ee37c4044275204b6f4379b1130204d02-dcba6bc357860cbbb3cd2955b94646c769f75e92.profdata to chrome-android32-main-1743810139-808b8531922b3368ef985d12de7bca2cf04f96f6-101be815a55131d39aecbbc80a0dc46b6b2dd61e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I85b7b6dbebc724ec7d120c961d18d1f20228f2a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435341
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443021}
Import wpt@2518df1a574171b618fabe4b7fea56b1e2c03485
https://github.com/web-platform-tests/wpt/compare/1fa883e06...2518df1a5
Using wpt-import in Chromium 309a671f65070cb1ea26dcaa85e450b8f8cacef4.
With Chromium commits locally applied on WPT:
77ab8bb837 "Reland "Reland "Ignore Letter Spacing in Cursive [...]
b6efc06262 "Reland "[carousel] Add invalidation logic and tests [...]
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
cbiesinger@chromium.org:
external/wpt/css/css-flexbox
meade@chromium.org:
external/wpt/web-animations
NOAUTOREVERT=true
R=rubber-stamper@appspot.gserviceaccount.com
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I49ad592c75ee228ef5766deee169be982eb0a9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434043
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443020}
[tab suggestions] Remove triggering for some types of tab selection
For some selection types, the selected tab is not intentionally
picked by users and therefore should not (1) increase foreground count
(2) trigger heuristics.
Bug: 397221723
Change-Id: I6e6762e3bc3a8781fdfa4c4e9bec06f89a4202ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6431471
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443019}
Roll clank/internal/apps from 9aba8609b0b8 to 5ffe29dcd62b (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/9aba8609b0b8..5ffe29dcd62b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,hanxi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: hanxi@google.com
No-Try: true
Change-Id: I577b7cf3c09b5bf85d6be379b1e4b679a9f95aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435455
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443018}
Use the right icon for glic sign-in panel
Bug: 407816938
Change-Id: I2eaa719f00137683465a2a9432c194fcd2aa1244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435371
Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Dan Harrington <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443017}
extensions: Port ChromeExtensionRegistrarDelegate to desktop Android
And replace (most of) the stub delegate implementation we have been
using so far. This makes extension install and uninstall much closer
to Win/Mac/Linux behavior.
UnpackedInstaller is currently being worked on, so it is #ifdef'd out.
Likewise, theme support is #ifdef'd out as well. Bugs are filed for
both.
An ExtensionSpecialStoragePolicy instance is added to the profile for ENABLE_EXTENSIONS_CORE. A ManagementPolicy instance is added to
DesktopAndroidExtensionSystem. Both are dependencies of
ChromeExtensionRegistrarDelegate.
Bug: 394968360
Change-Id: I0891f420a01c23e90fff358ac6549b8589d0b002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434815
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443016}
[iOS]Prepare account menu for AuthenticationFlowDelegate
In https://www.crrev.com/c/6383098, the authentication flow takes a delegate instead of a completion.
This CL prepares the account menu, ensuring the method that will become the completion takes only the argument needed by the completion; this is done by storing the two extra parameters in instance variable during the flow. As there is at most one flow at a time, this is no a change in behavior.
Bug: 375605572
Change-Id: I24fa90ff2f066bc324a17f12e456d8273f401e15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6425288
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443015}
Fix spacing issue for virtual card
Fix:
https://screenshot.googleplex.com/7b9nsFaU9geNEdB
https://screenshot.googleplex.com/BGBftX7iGSAY8mj
https://screenshot.googleplex.com/Awiu9JH88raYgjb
Bug: b:400468864
Change-Id: Ibfca697986bdc9c33c3d8403430bbad7776fb315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6429272
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Qihui Zhao <qihuizhao@google.com>
Reviewed-by: Harsh Shukla <hvs@google.com>
Cr-Commit-Position: refs/heads/main@{#1443014}
Remove `--load-extension` switch on Chrome builds
Part of an on-going effort to reduce harm from the malicious
command-line extensions, this CL removes the exploited switch
only on Chrome builds.
Bug: 401529219
Change-Id: I989dc9b3d50bbeb349b9e0a534945dd64d8c55cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335815
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Commit-Queue: Richard Chen <richche@google.com>
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443013}
[BNPL] Log ToS dialog accept, cancel results.
Design: go/chrome-bnpl-metrics-design
Bug: 356443046
Change-Id: I334f3b74f6ade4bf3a71012f68557b4848e219a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398325
Commit-Queue: Longsheng Yin <longsheng@google.com>
Reviewed-by: Olivia Saul <jsaul@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443012}
extensions: Port ComponentLoader to desktop Android
It is a dependency of ChromeExtensionRegistrarDelegate, which we are
trying to port to desktop Android.
Move one function body from ExtensionService to ExtensionRegistrar so
it can be accessed by ComponentLoader directly.
Convert ComponentLoader to a KeyedService so it can be accessed (in
future CLs) without accessing ExtensionsService.
Bug: 408454704
Change-Id: Ia5a4c88e4299d40ed07322a7c40c7be9e6af0a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6431575
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443011}
[lensoverlay] Limit page contextualization updates.
Removes updates that occur when the live page is not showing. Gates
recontextualizing on each query behind flag.
Bug: 408223189
Change-Id: Ifc72b64bddc1665c19eadcc569f248cadd4f5ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432286
Reviewed-by: Duncan Mercer <mercerd@google.com>
Commit-Queue: Bryan Nguyen <nguyenbryan@google.com>
Cr-Commit-Position: refs/heads/main@{#1443010}
[Surface Color] Settings
For both light & dark:
bg: surface
cards: surface container
dividers: surface container highest
bg is already set to color surface (default_bg_color)
dividers are already set to surface container highest (divider_line_bg_color)
Before:
https://screenshot.googleplex.com/iS98qTgwS9hiMLv
https://screenshot.googleplex.com/9b2E8J9DkBYhwnr
After:
https://screenshot.googleplex.com/JE4hc2ggC8FhUvx
https://screenshot.googleplex.com/3gQFDezWw4cRmx4
Bug: 399969276
Change-Id: I46ef50abfe1e78fa3f4dffafb7d2432d13146581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432712
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Eleanor Lee <eleanorlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1443009}
Revert "[enterprise][e2e] Disable tests failing due to blocked sign-ins"
This reverts commit 833f8971514692b8eefe54b35a28ba7530728d57.
Reason for revert:
OTA conversion fulfilled (b/406324035, b/408294519), accounts show up
in Rhea, and tests seem to pass now (at least locally).
Original change's description:
> [enterprise][e2e] Disable tests failing due to blocked sign-ins
>
> Bug: 403340476
> Change-Id: Iff246732f5bdad2b2a9b145b37b7aa2944e30d44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354864
> Reviewed-by: Xiang Ji <jxiang@google.com>
> Commit-Queue: Xiang Ji <jxiang@google.com>
> Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
> Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
> Cr-Commit-Position: refs/heads/main@{#1432388}
Bug: 403340476
Change-Id: I7e5df6fbdf455ab658e6be7e89744101944ed6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403962
Reviewed-by: Xiang Ji <jxiang@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1443008}
Roll Perfetto from 235088d2c92b to 37ab985dbbc7 (1 revision)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/235088d2c92b..37ab985dbbc7
2025-04-04 tikuta@google.com proto: Add generator_visibility to "//protos/perfetto/config/chrome:scenario_@TYPE@" (#1144)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC khokhlov@google.com,perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: khokhlov@google.com,perfetto-bugs@google.com
Change-Id: I4d27689e469867a1cfa4acaf66c1ec37109e9ca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435180
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443007}
[GTK] Fix selected text colors on some GTK4 themes
GTK4 adds the "focus-within" pseudoclass which needs to be applied to
focused elements like text selections.
Also remove GetSelectionBgColor() since it's now identical to
GetBgColor() after support for GTK 3.19- was dropped.
R=thestig
Fixed: 408062957
Change-Id: I5152039c093524b052197df9de6fcb537d70f099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435370
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443006}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1743801037-1afb60a8eb486da70b04d17831b06528428cbb3f-e2f325ec0c5f781750f25a16e50fe28f56db7a4b.profdata to chrome-android64-main-1743806261-7afbd80151dc4c210a2d298ffc9e6f88f0cef4f1-8c2ee4725c62b7b20189050144c40431b0f36ca9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Iead3f17e44929882422d913aa5959ebd54bae5f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435415
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443005}
[Shared Tab Groups] Add more waiting in tests
The new service is asynchronous, and because of that we have to wait
in all of the new tests that use the sync service directly.
here we add more Waits because we have unittests which are flaky.
Fixed: 407973662
Change-Id: I5f88734265ade47081ab536f87ebcfb492ffee8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435200
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443004}
extensions: Remove call to GetOriginalProfile() in DataDeleter
The profile passed in to this function is always on-the-record, so
there's no reason to GetOriginalProfile(). I added a DCHECK for clarity.
Bug: none
Change-Id: I144b56024c00932bb0cef52b45dc68801af24ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435166
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443003}
[omnibox][spark] Update `OmniboxProviders` histogram variants
Adds 4 providers:
- ContextualSearch
- EnterpriseSearchAggregator
- RecentlyClosedTabs
- UnscopedExtension
Affects 3 metrics:
- Omnibox.AsyncAutocompletionTime2.*
- Omnibox.ProviderTime2.*
- Omnibox.URLScoringModelExecuted.ScoringSignalCoverage.*
Bug: 408478172
Change-Id: Iedc5e80f4adcdc9ba7227ec3b8ca4692a69e2622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434810
Auto-Submit: manuk hovanesian <manukh@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Ananya Seelam <ananyaseelam@google.com>
Cr-Commit-Position: refs/heads/main@{#1443002}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1743803867-e8bbed1a346b015e42df1e00fe53e6ac691631e8-9df6c4a97c31511dc274185cee56c647fef12d8a.profdata to chrome-mac-arm-main-1743810139-94df8eff1b18b89ab9f33ca052f87b663e97ebad-101be815a55131d39aecbbc80a0dc46b6b2dd61e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I35208b8970ce95a8163f58504ae81d5e40763b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435394
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443001}
Roll Release Scripts from 7a1b710cf5b5 to b76782dd2df9 (1 revision)
https://chrome-internal.googlesource.com/chrome/tools/release/scripts.git/+log/7a1b710cf5b5..b76782dd2df9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/release-scripts-chromium
Please CC chrome-release-infra@google.com,jiesheng@google.com,morawand@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jiesheng@google.com,morawand@google.com
Change-Id: I0ecd6162c16416fa590482c821723dad4b402899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435176
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1443000}
Add a PassKey to RegisterDeleteDelegateCallback().
The passkey's constructor will be made private in the future, so that no
additional callers can be added.
Bug: 407812144
Change-Id: Idcbb1fcb74013e088cdfb46475d6d13c28055fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6433203
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442999}
[fuchsia] use streaming and increase buffer-size to ensure the comprehensive of the trace
I noticed the issue when trying to trace the perf of
web-engine in v8.browsing_mobile tests.
By default, ffx trace drops the data when the buffer is full. By
using streaming buffering mode, the data will be written into the
trace file instead.
Cq-Include-Trybots: luci.chrome.try:fuchsia-ava-astro
Change-Id: Id4ef3193e8a4437960dee2473177d66302017aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427120
Auto-Submit: Zijie He <zijiehe@google.com>
Commit-Queue: David Song <wintermelons@google.com>
Reviewed-by: David Song <wintermelons@google.com>
Cr-Commit-Position: refs/heads/main@{#1442998}
Revert "Manual roll Android Lint from cpi5krkjlhoCfjDOZ... to vBqKHQdjLFM5l79fp..."
This reverts commit c12d388b70687b801d11dae3440ac2bbfc19220c.
Reason for revert: Causing failures on android builders:
https://ci.chromium.org/ui/p/chromium/builders/ci/android-cast-arm-dbg/8005/overview
Original change's description:
> Manual roll Android Lint from cpi5krkjlhoCfjDOZ... to vBqKHQdjLFM5l79fp...
>
> Maual: Suppress the lint error,
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/lint-chromium
> Please CC clank-build-core@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Tbr: clank-library-failures@google.com
> Change-Id: Iccc0be25ec30e92baa18a5a4398bd1acbb85049b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432318
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Haiyang Pan <hypan@google.com>
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1442987}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I28ccdebc6011f7b157a01f2c43af9fe5245f19e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434798
Reviewed-by: Haiyang Pan <hypan@google.com>
Owners-Override: Nathan Memmott <memmott@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442997}
Update TTS engine to v1.6
Roll src/third_party/wasm_tts_engine/src/ 53d2aba6f..18eab9bfc (1 commit)
https://chromium.googlesource.com/chromium/wasm-tts-engine/+log/53d2aba6f0cf..18eab9bfc2ac
$ git log 53d2aba6f..18eab9bfc --date=short --no-merges --format='%ad %ae %s'
2025-04-04 lwinston No public description
Created with:
roll-dep src/third_party/wasm_tts_engine/src
Bug: none
Change-Id: I4603bf68992efd5727b1ba92dd0c0dee87162cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434866
Commit-Queue: Lauren Winston <lwinston@google.com>
Reviewed-by: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1442996}
Remove about:flags entry for DeferRendererTasksAfterInput
We're keeping the feature flag around for a while so that automated
testing tools can disable the feature, but we can remove the (expired)
flag.
Fixed: 394151944
Change-Id: I9e9d6c996f6ae4ee658ded6a76b990fcea2504c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405587
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442995}
Roll ANGLE from 5462a5286288 to 2a4ea88e15b6 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/5462a5286288..2a4ea88e15b6
2025-04-04 lexa.knyazev@gmail.com Simplify CopyImageSubData validation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: romanl@google.com
Change-Id: If49e6cda4de1654a6349c253129ce5b3c0fcecb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435330
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442994}
[Read aloud] Don't speak punctuation only when resuming speech
Bug: 40927698
Change-Id: I19a59a9a7620a6eae63671bd04e35072b67ddd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427155
Auto-Submit: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Commit-Queue: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1442993}
Create a new graphite:Context wrapper class GraphiteSharedContext
To support multithreading for graphite::Context, we introduce a new
wrapper class GraphiteSharedContext that uses a lock to ensure
graphite::Context is thread safe.
GraphiteSharedContext in this CL is pretty much empty. More content will
be added later.
Bug: 407874799
Change-Id: I58bd2f3f4f834bbc280ec44b95b015e43676bfca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6425059
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442992}
Remove kEnableFileBackedBlobFactory feature declaration
Drive-by cleanup. kEnableFileBackedBlobFactory was removed in
crrev.com/c/5882178, but the declaration was still in features.h.
Bug: 361119171
Change-Id: I2b047da42e74f30184cf239fedf4719e8ea86c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405876
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442991}
Roll vulkan-deps from 31c2a218dfc5 to 1e4361042837 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/31c2a218dfc5..1e4361042837
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c3d39de93955f884e443c39e9ffecf86e4aac883..4a038eafdf9e9f3e0ac2e200127df969f3a51ddb
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/81ea0feb931d71912e13b5c689aab2d436757d0d..77caa409bdb901611c9713bc59db7e46867943c7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC angle-team@google.com,bajones@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,romanl@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel
Bug: None
Tbr: bajones@google.com,radial-bots+chrome-roll@google.com,romanl@google.com
Change-Id: I298624b654069747d6d2a98de1722f015e028883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435220
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442990}
[Extensions] Refactor UserScriptsAPITest to be importable by others.
This is a no-op refactor to allow UserScriptsAPITest to be #included in
a child UI test that can reuse some of the functionality of the class,
but primarily keeps the extension_features state consistent across
tests.
Also while I was at it I removed some seemingly unused includes and one
testing method that was unused.
Bug: 390138269
Change-Id: I5edebe4a8f19f775f18795d363678f5be0fe0f38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6428687
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442989}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1743767741-c1049c87856b5b48503d7554c2e07cd7c09a1224-9c3af792fe4963fc1d0862267977d76a0c29b0b6.profdata to chrome-win64-main-1743778663-9f8ca5bf48a3883bcd0639cb5807868cc3f4c395-ebb2ca986a1bc6a9270ad30895ff1fd026371bc5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ib82d0575feba248d20c22dc54a80f0561faae3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434382
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442988}
Manual roll Android Lint from cpi5krkjlhoCfjDOZ... to vBqKHQdjLFM5l79fp...
Maual: Suppress the lint error,
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/lint-chromium
Please CC clank-build-core@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: clank-library-failures@google.com
Change-Id: Iccc0be25ec30e92baa18a5a4398bd1acbb85049b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432318
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442987}
[Read aloud] Fix skipping some text in pdfs
The issue was that GetNextSentence was returning the same AXPosition so
we were skipping to the next paragraph which skipped text. I added a
check for next line in pdfs since pdfs are sometimes laid out that way.
Fixed: 407021728
Change-Id: I69ad804bab95e5377050f5716b5f12f46a39706b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435035
Reviewed-by: Lauren Winston <lwinston@google.com>
Auto-Submit: Kristi Saney <kristislee@google.com>
Commit-Queue: Kristi Saney <kristislee@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1442986}
Move a number of inner classes to top level.
This allows them to be forward-declared, which will be necessary to make
them friends of the various WidgetDelegate passkeys.
Bug: 407812144
Change-Id: I57f0042d98f778a6b06c982bcace9b0c4a8626c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434999
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442985}
Task Manager Refresh - Increase refresh time
- In the refreshed task manager, the tasks should update at a slower
pace to avoid tasks jumping around.
Bug: b:408418110
Change-Id: I19537b69ba3731c329348a0ade999a24453dd7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6434721
Auto-Submit: Michael Wojcicka <mwoj@google.com>
Commit-Queue: Zhengzheng Liu <zhzhliu@chromium.org>
Reviewed-by: Zhengzheng Liu <zhzhliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442984}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1743796410-b7b0e7a71355e16d0f4923478952ca3efb98edb8-04b677333e27dc4f53bb7417231e84a19bdfc08a.profdata to chrome-android64-main-1743801037-1afb60a8eb486da70b04d17831b06528428cbb3f-e2f325ec0c5f781750f25a16e50fe28f56db7a4b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ic25f14523b8cb6a98a55f1af2b89f8181b52e45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435177
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442983}
Roll WebGPU CTS from af188cab7eaa to de07a4258079 (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/af188cab7eaa..de07a4258079
2025-04-04 kainino@chromium.org Try to destroy all devices on page/worker teardown (#4329)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: None
Tbr: bajones@google.com
Change-Id: I1f52bef068ed73bfc71b52c6034a569ddff07456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432322
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442982}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1743767741-cf197ba43c849232904500484de2fbc44b1e03f6-9c3af792fe4963fc1d0862267977d76a0c29b0b6.profdata to chrome-win-arm64-main-1743789549-902c7b47478fcdc3a60a5c578fb74fe4da2d77b9-dcba6bc357860cbbb3cd2955b94646c769f75e92.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3dfcfd77826845a3316b1c0159e945d4939a14a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435179
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442981}
[PWA] Make UninstallApps() API private, clean up fake version
This CL makes the following changes:
1. Makes the UninstallApps() API private and not be able to be overriden
as that is not a public interface of the ExternallyManagedAppManager.
2. Removes the handle_uninstall_request_callback_, and rewires tests to
use the public interface for testing instead, mimicking production more
closely.
The initial plan was also to do the same for InstallApps() in this same
CL, but a lot of existing tests use it wrongfully by completely
bypassing the install flow and causing problematic behavior. This is
punted to a follow-up.
While this is an overall no-op on production, this makes it easier to
remove FakeExternallyManagedAppManager in the future.
Bug: 407549320, 407797639
Change-Id: I76369de79d1479dbb683cc487b078c800ee26802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6431760
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442980}
Add a method for getting the FRE dismiss state for Glic
This also updates the SetFreCompletion methods to take in FreStatus
Bug: 408228040
Change-Id: Id4596581549467807b8be63cf947cee83bb3fd67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6430906
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442979}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1743796717-cb3ceb7cf1641ed4526d876b07b346ff37f0bec7-3583e94b4f532af4ff77c99c761596d449247fc9.profdata to chrome-mac-arm-main-1743803867-e8bbed1a346b015e42df1e00fe53e6ac691631e8-9df6c4a97c31511dc274185cee56c647fef12d8a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I0cc5b132996ee803ba2da99a0d5e386a3d7e09ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435082
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442978}
Roll ios_internal from 0a1e276957da to 9451e8b4d700
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/0a1e276957da..9451e8b4d700
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,ginnyhuang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ic68c747cd016f328ed5f61c2a7354bd9c0cef9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435208
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1442977}