Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Roll src-internal from d6d93d035c8e to 86024ec8f24d (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6d93d035c8e..86024ec8f24d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,mikt@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:330806166
Tbr: mikt@google.com
Change-Id: I94316993fcb696dd453d4664b553e6acd2b44740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486736
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292246}
Update expiry of some Net.SpdySession histograms.
These metrics are worth keeping.
Bug: 330166141
Change-Id: Ica3eabfe8f9936970132d912a8e09a79fa21cc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485966
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292245}
[URL] Make URLBlocklistManagerTest pass with non-special URL feature
URLBlocklistManagerTest is one of the tests which would fail when we
enable the StandardCompliandNonSpecialSchemeURLParser feature
[^1][^2]:
The test currently uses a non-special URL, like "about://newtab".
When the feature is enabled, the host part in non-special URLs can be
correctly parsed. That's why the test would fail with the feature
enabled.
See the following URL parser tester for details:
https://timothygu.me/urltester/#input=about%3A%2F%2Fnewtab
hostname:
> whatwg-url : "newtab"
> Chrome: (empty string)
This CL makes the test pass, regardless of whether the feature is
enabled or not, by making the test a parameterized test and adding
expected outputs when the feature is enabled, in preparation for
enabling the feature.
Though the main purpose of this CL is to make the test pass when the
feature is enabled, I'd like to notify a code owner that we are
changing the behavior of non-special URLs via this CL's review. Since
I'm not familiar how URLBlocklistManager should work for non-special
URLs (e.g. "about://", "chrome://" URLs here), it's recommended for a
code owner or a domain expert to review and potentially do an
appropriate action in a follow-up CL, if necessary.
Depending on the severity of a potential breakage, I'd appreciate if
you could file a bug and marking it as blocking for bug 40063064 so we
don't ship the feature until all critical issues are addressed.
[^1]: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1752691/test-results
[^2]: https://docs.google.com/spreadsheets/d/1Pqw1iKXK_lxHj-kLIAeRFs-khFz-BPZDio1W7SgEVE4/
Bug: 40063064
Change-Id: I63bf7c91462d1cf866e74b463b7326cca63a4467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474919
Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292244}
Roll Catapult from 2ac3ee8be369 to 01d7072ad67e (1 revision)
https://chromium.googlesource.com/catapult.git/+log/2ac3ee8be369..01d7072ad67e
2024-04-24 ashwinpv@google.com Update pinpoint version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC ashwinpv@google.com,chrome-speed-operations@google.com,dberris@chromium.org,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:336768723
Tbr: ashwinpv@google.com
Change-Id: I83199594e38e8775a717c90def44ceaf7a4f924a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485711
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292243}
views: use CalculatePreferredSize(SizeBounds) in //ash/style.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: I9a5f4a662b904635a10308d6fde5d8df46bb8335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467276
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Xiaodan Zhu <zxdan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292242}
RubyLB: Support position:relative in annotation lines
Relative position computation needs an InlineLayoutStateStack instance,
and should be applied after RubyBlockPositionCalculator(). So this CL
makes an InlineLayoutStateStack a data member of LogicalRubyColumn.
Bug: 324111880
Change-Id: I1ff26bf11484185cf0ab94912b2c08da2b220c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484267
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292241}
views: use CalculatePreferredSize(SizeBounds) in //ash/components/arc/compat_mode.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: Ib8602b2aec098eb2de7e66361da6a04a828046e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469926
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292240}
views: use CalculatePreferredSize(SizeBounds) in //ash/accessibility.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
Bug: 40232718
Change-Id: I62238cee1e97b17b1c7ad5bc368fcab93fdaa467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469709
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292239}
Roll optimization-guide from 884eef64c843 to 73f3778a3e87
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/884eef64c843..73f3778a3e87
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:336820158
Change-Id: I42e74b5e3138722a46696587705cd3da77c21a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485719
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292238}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1713981585-c7832876f1eff26ec7d36b041206ea3d2ed6f2eb-c04208c2fc20057f99c9b1c44a42b36469a9f9b8.profdata to chrome-android32-main-1714003166-cdc9c8ddf9a566fee06626016480f51d50885683-5c1e239c8edda7e1b998ca561e67a2e0d55312c7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia8db8dded5d57feff6692310c5e01cc10a4a8f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485580
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292237}
Enable CrOSLateBootSwapZramRecompression feature by default
Feature is ready to be launched on 100% Stable.
Bug=b:298083294
Change-Id: Id06ee8b576ae20e5fdb70ab97d2e4af6376b9c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463563
Reviewed-by: Vovo Yang <vovoy@chromium.org>
Commit-Queue: Chun-Tse Shao <ctshao@google.com>
Reviewed-by: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292236}
Fix history query state bugs
- Fix bug where changing only the search term from the toolbar input
would clear out the selected after date.
- Fix bug where changing the after date to undefined was not calling
the compute function, so the `queryStateAfterDate_` never got updated.
The app now listens for any subproperty changes to `queryState_` so
that it catches updates when `queryState_.after` becomes undefined.
Bug: 333936671
Change-Id: I7829f89b318109542b035030b2dcc11c25a5c138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480393
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292235}
Roll Perfetto Trace Processor Linux from 763aab383f2e to 234fd02711c6
https://android.googlesource.com/platform/external/perfetto.git/+log/763aab383f2e..234fd02711c6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I3c5967346744c703ede88d86a8f5f88ada1b4c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484382
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292234}
[lensoverlay] Add cursor.
Demo: https://screencast.googleplex.com/cast/NTI4OTMyOTAwOTA5ODc1Mnw5ZmUzZTcxYy05ZQ
Bug: b:336371952
Change-Id: Icb6dd9c6e488366336c653d3a37c079b76b804f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480791
Reviewed-by: Duncan Mercer <mercerd@google.com>
Commit-Queue: Bryan Nguyen <nguyenbryan@google.com>
Cr-Commit-Position: refs/heads/main@{#1292233}
[CrOS Cellular] Disallow editing APNs when APN modification disallowed
Update <apn-list-item> to display the APN detail dialog in "View" mode
when APN modification is disabled.
Bug: b:333100319
Test: On device, *ApnListItem*
Change-Id: I118ef9a78e2cf9d1f112acd24b95bab125bcab02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480307
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/main@{#1292232}
Disable flaky secagentd.AuthenticationEvents.mainline
Bug: b:336365285
Change-Id: I8407c4a2e180b837fcf9df79a144daf4a98cb26c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486511
Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org>
Commit-Queue: Michael Wojcicka <mwoj@google.com>
Cr-Commit-Position: refs/heads/main@{#1292231}
RubyLB: Move LogicalRubyColumn definition
This will make following CLs smaller.
This CL has no behavior changes.
Bug: 324111880
Change-Id: I07754680db03cbeffbbd4ddd968a0749090e55b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481847
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292230}
[DeferUnusePreload] Add LcppDeferUnusedPreloadPreloadedReason param
This CL adds the new feature param to DeferUnusePreload.
In general we have two types of preloads. One is the developer initiated
preload, the other one is the browser initiated preload. We can tell
them via `IsLinkPreload()` and `IsSpeculativePreload()` in
FetchParameters.
The new feature param, called `LcppDeferUnusedPreloadPreloadedReason`
adds the limitation to the DeferUnusedPreload eligibility based on this
two types of preloads.
Bug: 332382758
Change-Id: I389d00620f2b46b5891f1bb9c5e3ec521326cf1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465235
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292229}
[DeferUnusePreload] Start loading via LCPTimingPredictor
This CL add the option to start loading via LCPTimingPredictor. Before
this CL, the deferred preload starts loading via PostTask, but
LCPTimingPredictor gives more effective timing to trigger the deferred
preload request.
Bug: 332382758
Change-Id: I5e3bcc832737a34c102bf8bb1a09f65af108973a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465151
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292228}
Remove CSSUpdateMediaFeature flag
Flag has been enabled since M113.
Bug: 40552742
Change-Id: I4b1554d455f6cd2e4f17aa04c3740d2627194070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480387
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292227}
Use IsOutermostMainFrame for isolated app main frame.
This code was added in https://crrev.com/c/3525496 using `!parent`.
In later https://crrev.com/c/3593376 the advice was to use
IsOutermostMainFrame (although one more `!parent` was added in that too).
This updates the code to use IsOutermostMainFrame, making it
consistent.
Change-Id: I362197086f7e95623dcc88b88c0e59f23f319fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480947
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292226}
[Cleanup] Update code references and clarify terminology
* Omit redundant `optimization_guide` namespace
* Update a comment to reference the correct `enums.xml` file (recently branched)
* Clarify comments around whether metrics reporting is enabled.
R=curranmax@chromium.org
Bug: none
Change-Id: Ie4a316c2d1327dd8636d1f4e52eb582f5a75840b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467083
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292225}
metrics: Add VMMS reclaim duration variants
Add variants for VMMS reclaim duration based on the current memory
pressure observed by resourced.
Bug: b/325156127
Change-Id: Idd302d32bb0e2f00fd5c91a10ae7f0528c8b1485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463444
Reviewed-by: Howard Yang <hcyang@google.com>
Commit-Queue: Kameron Lutes <kalutes@chromium.org>
Reviewed-by: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292224}
[DeferUnusePreload] Preload requests via PostTask if likely unused
This CL changes the preload dipatch timing by using LCPP. From LCPP
hints, ResourceFetcher looks at the potentially unused preload URLs hint
and schedule a task to dispatch resource loading instead of starting
immediately.
This is the basic implementation of this feature. Several ideas to
change the request dispatch timing will be implemented in next CLs.
Bug: 332382758
Change-Id: Ief7451fab7602be2cd4aa9660a4568e418eff19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447206
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292223}
[PWA] Cleanup references to DesktopPWAsEnforceWebAppSettingsPolicy
This CL cleans up references to DesktopPWAsEnforceWebAppSettingsPolicy
in an attempt to clean up stale base features as specified in
go/stale-base-features that do not have corresponding Finch configs and
have been enabled for more than 10 milestones.
Bug: 336755887
Change-Id: Ibd943458de68b77ab8933c9fcc8d8f1b0a0120c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483826
Auto-Submit: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292222}
Migrate generic structs and utils to //chromeos/ash/components.
Migrates the util functions for system information into a new
component called system_info. A new component called launcher_search
is also created for the functions which are specific to the launcher.
These functions are related to obtaining system diagnostics information
from a ChromeOS device. They are required within the ChromeOS
Launcher, and also for other features within ChromeOS.
Bug: b/336160468
Change-Id: I68f70162b27cf5e4ff05281172eeb09895947603
Test: Unit tests and also tested on a DUT.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471023
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Lauren Commeignes <laurencom@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292221}
Convert base::StringPiece to std::string_view in //ch/b/ui
The changes of this CL are made using the following script.
Script: https://issues.chromium.org/issues/40506050#comment343
Bug: 40506050
Change-Id: I457b67b57e984aba546c27faec000fa19a6b7147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471690
Commit-Queue: Helmut Januschka <helmut@januschka.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292220}
events: Implement modifier rewriting for right alt
Implements event rewriting for the right alt key which is able to be
remapped to all other modifiers and vice-versa.
Fixed: b/331859873
Change-Id: I2a9f4bb0a1b81a345685d0d3282844fe5f68f137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375407
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: David Padlipsky <dpad@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292219}
WebUI help-bubble: Default to CR2023 styles
Bug: 326116364
Change-Id: Iba973c8bf2735fc11938d5f8a1fba500fff49736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486154
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Teresa Mao <temao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292218}
[lacros skew tests] Refresh skew tests for M123
This CL updates the ash version ['123.0.6312.134'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I8353494b67c1e30ccadda69c52eddbd4cc2512c0
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486556
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292217}
snap-groups: Refresh for work area and snap to replace
This modifies `ApplyPrimarySnapRatio()` to verify the windows can fit
in the snap group, and introduces `RefreshSnapGroup()` to either break
the group or call `ApplyPrimarySnapRatio()`. This will be used by
work area changes and snap to replace to refresh the group bounds.
Test: SnapGroupTest*
Bug: b/333623218, b/335343444
Change-Id: Ieaa21cca13d324c81665a113868aa9de9d2b1dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5460979
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292216}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1713981585-8bdcc01511c797767aa5364efb1505763d308bc6-c04208c2fc20057f99c9b1c44a42b36469a9f9b8.profdata to chrome-win64-main-1713992391-ca12bb9bb61f1c0d6142f76077793c6b66edce73-f53c86cd76243ef68f87022047f02510109bfeea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9f58b2105d2e588c953886b9e90aac55c6d550a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485707
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292215}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1713981585-309cab7c1040ec498ed011e23fa980a862fc7b12-c04208c2fc20057f99c9b1c44a42b36469a9f9b8.profdata to chrome-win32-main-1713992391-39e9ffac7dcd22518d571ca779d9d5f927db0e04-f53c86cd76243ef68f87022047f02510109bfeea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I412d4c8e5aa948aa07a7478bb3bd208bb6c0fa30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485516
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292214}
Roll WebRTC from e92b143eea2d to caa1201a0800 (4 revisions)
https://webrtc.googlesource.com/src.git/+log/e92b143eea2d..caa1201a0800
2024-04-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f24efc069c..8b3f58c31e (1291744:1292052)
2024-04-24 eshr@google.com Add perfetto build config
2024-04-24 danilchap@webrtc.org Delete deprecated CreateVideoEncoderSoftwareFallbackWrapper
2024-04-24 phancke@meta.com sdp: cleanup WebRTC-PreventSsrcGroupsWithUnexpectedSize killswitch
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:40066610
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I62583e5b1f9afdcece47ab8d4dcdca8f2fe5682a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486075
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292213}
Revert "Roll Perfetto from 234fd02711c6 to 196f4d514c28 (53 revisions)"
This reverts commit 1fd14d08d3208244737a2e88ba48a74aac9982e6.
Reason for revert: Broke UBSan
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/29667/test-results?sortby=&groupby=
Original change's description:
> Roll Perfetto from 234fd02711c6 to 196f4d514c28 (53 revisions)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/234fd02711c6..196f4d514c28
>
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Fix `uint` -> `uint32_t`" into main
> 2024-04-24 oksamyt@google.com Merge "Update chrome_scroll_inputs_per_frame.sql to use EventLatency" into main
> 2024-04-24 ddiproietto@google.com Merge "Use `am get-current-user` instead of `cmd user get-main-user`" into main
> 2024-04-24 stevegolton@google.com ui: Tidy up commands
> 2024-04-24 stevegolton@google.com Merge "ui: Fix double scrollbar sometimes seen in Ftrace/Android logs tabs" into main
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Improve dominator tree view performance" into main
> 2024-04-24 keanmariotti@google.com Merge "protozero: allow top-level extension blocks" into main
> 2024-04-24 vilasbhat@google.com Merge "perfetto: Fix issues with proto update tools on tip-of-tree" into main
> 2024-04-23 lalitm@google.com Merge "ui: overhaul track decider queries to make things faster" into main
> 2024-04-23 vaage@google.com Merge "Trace Redaction - Frame Timeline" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "protozero_plugin: print extensions" into main
> 2024-04-23 lalitm@google.com tp: implement an implicit segment-tree like data structure
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Revert "protozero_plugin: print extensions"" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Fix segfault in trace processor" into main
> 2024-04-23 lalitm@google.com tp: fix multiple minor bugs with cengine
> 2024-04-23 lalitm@google.com ui: remove arg autocompletition in pivot table
> 2024-04-23 rsavitski@google.com Merge "ui: change "dead" task color to gray and render dead tasks from old kernels (<4.14)" into main
> 2024-04-23 etiennep@google.com Merge "[chrome] Register MetadataModule for kChromeTriggerFieldNumber" into main
> 2024-04-23 oksamyt@google.com Merge "COPYBARA_IMPORT=Project import generated by Copybara." into main
> 2024-04-23 bql@google.com Merge "Revert "ui: show heap graph dominator tree default to true"" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "proto_gen.bzl: emit --proto_path for dependencies" into main
> 2024-04-23 rasikan@google.com Merge "[chrome-stdlib] Fix OWNERS file for Chrome Stdlib" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "improve typescript docs" into main
> 2024-04-23 ddiproietto@google.com protozero_plugin: print extensions
> 2024-04-23 keanmariotti@google.com Merge "Build perfetto_trace_javastream_protos from list of files" into main
> 2024-04-22 vaage@google.com Merge "Trace Redaction - Drops fields, not packets" into main
> 2024-04-22 rsavitski@google.com ui: promote Steve to owner of chaos
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from src/traced/probes/ftrace/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/src/plugins/dev.perfetto.BookmarkletApi/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/release/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from test/vts/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from test/cts/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from src/trace_processor/perfetto_sql/stdlib/common/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from protos/perfetto/ipc/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from infra/OWNERS" into main
> 2024-04-22 aattar@google.com Merge "[ETW] Fixes two main UI issues with ETW" into main
> 2024-04-22 stevegolton@google.com Merge "ui: Fix buggy counter duration calculation" into main
> 2024-04-22 rasikan@google.com [chrome-stdlib] Add Chromium owners to subdirectories of Chrome Stdlib
> 2024-04-19 stevegolton@google.com ui: Roll canary
> 2024-04-19 simonmacm@google.com Merge "Proto definitions for modem custom data source. Bug: 335603768" into main
> 2024-04-18 stevegolton@google.com Merge "ui: Fix broken table header CSS" into main
> 2024-04-18 bql@google.com Merge "ui: show heap graph dominator tree default to true" into main
> 2024-04-18 amanvr@google.com Merge "COPYBARA_IMPORT=Project import generated by Copybara." into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Fix indirect include" into main
> 2024-04-17 simonmacm@google.com Don't show '?' for unknown units.
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Filter suspend resume events" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Update filter ftrace events to use common fixture" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Update scrubs ftrace events to use common fixture" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Extract prune package list tests" into main
> 2024-04-17 stevegolton@google.com Merge "ui: Defer invoking `Track.onCreate()` until the track is in view" into main
> 2024-04-17 aattar@google.com Merge "[ETW] Adds EtwParser and EtwShedEventTracker to trace processor." into main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
> Bug: chromium:276433199
> Tbr: perfetto-bugs@google.com
> Change-Id: Iaf33f581fcc62aca6d21092c5c744c64a8d2f090
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484214
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1292043}
Bug: chromium:276433199, 335456429
Change-Id: Ie43d2d847cde701616d1b5547caa1697f199c192
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486716
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Mikihito Matsuura <mikt@google.com>
Cr-Commit-Position: refs/heads/main@{#1292212}
Revert "Roll Perfetto from 196f4d514c28 to 763aab383f2e (1 revision)"
This reverts commit 41f70025d26bdabe4a0c175336d6249cfd47a098.
Reason for revert: to revert https://crrev.com/c/5484214
Original change's description:
> Roll Perfetto from 196f4d514c28 to 763aab383f2e (1 revision)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/196f4d514c28..763aab383f2e
>
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "tp: fix subtle issue with process <-> package matching for isolated apps" into main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
> Bug: None
> Tbr: perfetto-bugs@google.com
> Change-Id: I15c426de93d29f4793bae0cd9254b5a211abd120
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484465
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1292113}
Bug: None
Change-Id: I1460c7c30d12393103ba43da3fee7e6750725f21
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486796
Auto-Submit: Mikihito Matsuura <mikt@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292211}
Multi-Calendar: Add metrics
+ Added metrics to record the calendar list fetch duration, error
code, whether or not the request timed out, and the total amount of
selected calendars in the user's calendar list.
+ Added a metric for the total duration of a single month's calendar
event fetches.
+ Split TimeToSeeTodaysEventDots into single-calendar and multi-calendar
metrics.
+ Parameterized the post-login glanceables metrics recorder calendar
fetch test.
+ Added calendar list model metrics tests.
Bug: b:308699414
Change-Id: I04d21bc8ecab97879420585dcaa8bf1423b7fa8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454602
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org>
Reviewed-by: Courtney Wong <courtneywong@chromium.org>
Reviewed-by: Michele Fan <michelefan@chromium.org>
Commit-Queue: Amber Haynes <amberhaynes@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292210}
Update voice install status even if there are no natural voices
Followup on crrev.com/c/5474663. Not every downloaded voice pack has
natural voices, so remove that step. I also filter with availableLangs
rather than availableVoices because we were doing extra work since
there's multiple voices per language.
Fixed: 336280327
Change-Id: I6e73130f6d34425bc0631a9ddf7786788c0b6f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484772
Auto-Submit: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1292209}
Migrate ScreenlockMonitorDeviceSourceWin to SingletonHwnd
The current implementation of ScreenlockMonitorDeviceSourceWin
creates message-only windows to listen for events from Windows.
This impacts performance at startup where we have to pay the cost to
creating the window to listen. Instead use Singleton HWND in the
implementation of this component to allow sharing a single HWND. We
typically see 1-10ms costs for creating HWND in startup, so sharing the Singleton HWND will lead to modest but measurable startup improvements. Additionally, to support tests, the creation of singleton hwnd observerin BrowserAccessibilityStateImplWin is deferred to InitBackgroundTasks(). Originally, the SingletonHwnd in content_unittests was not initialized on the UI thread. This meant that OnWndProc was not called in ScreenlockMonitorDeviceSourceWinTest. The fix was to defer the creation of the singleton observer from BrowserAccessibilityStateImplWin() to InitBackgroundTasks() so the BrowserTaskEnvironment can be set first and the Singletonhwnd is created on a UI thread.
Bug: 40285703
Change-Id: Ia818e2dd8fb67ce21b14887f335d29c6895509cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469064
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Ishika Patel <ishikapatel@microsoft.com>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292208}
CrOS Settings: Create settings-dropdown-v2 element
Creates a new dropdown element with pref control capability. Non-pref
capability is deferred to a separate CL.
Bug: b:333454399
Test: browser_tests --gtest_filter="*OSSettings*SettingsDropdownV2"
Change-Id: Ie55ef075e763f7b086c95113038535d7486ab361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479487
Reviewed-by: Connie Xu <conniekxu@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1292207}
[Tab Group Sync] Replacing int by Token in native
This CL replaces the tab group ID data type in native to
base::Token from int.
Bug: 336663675
Change-Id: I7dc52fe4eb9f42a5b50829946051d6b8e164a897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481808
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292206}
[ASH] Remove extra divider line in CCT history info header
Bug: 332570741
Change-Id: Id506520a307f091970949bb3eb4752af01011e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484423
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292205}
Roll optimization-guide from 18abeb373b57 to 884eef64c843
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/18abeb373b57..884eef64c843
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Id9ae7e4ee98536bd36074c3b9251e839714c7bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486076
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292204}
Remove kForYouFre feature flag check from intro_ui.cc
The feature is now fully launched. This is part of the cleanup process.
Fixed: b:336751237
Change-Id: I7a4bcbb0880099f8d3ba4c9805ec20f48d8f2cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481951
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Auto-Submit: Jack Yammine <jyammine@google.com>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292203}
[declutter] Plumb through boolean for inclusion in native TabModelList
Add a boolean to the TabModel constructor to indicate whether to include
the TabModel in the static TabModelList tracked in native. This static
list is used by sync types like sessions & send tab to self to observe
Tab/Models in Android. The archived tab model is the only current case
where this boolean is set to false.
Bug: 336581953,333582560
Change-Id: Iee0dd9a8e06185461dc9ba17b78e6ebbd3850724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478413
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1292202}
Wire overlay panel visibility and color to BottomAttachedUiObserver
https://screencast.googleplex.com/cast/NjI1ODA3OTU5NDE4NDcwNHw2ZTllOGQ5Yy1iYg
Bug: 329287585
Change-Id: Id7d85a762d827ffad24f651767db7e2d9b7623e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472457
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Charles Hager <clhager@google.com>
Cr-Commit-Position: refs/heads/main@{#1292201}
[Tab Group Sync] Implement getDeletedGroupIds
This CL completes the hookup of getDeletedGroupIds across JNI.
Deleted groups are groups that have been deleted from sync but open
locally. These groups will be closed in the tab model on the next
restart of the window if the window is not alive when the message was
received from sync. If the window was open, the group will be closed
and the entry will be deleted right away.
Also adds a few TODOs in tab_group_sync_service_impl.cc to invoke
mapping store when it's ready.
Bug: b/336792770
Change-Id: Id58f9e9babcc79cab9f6802e89c9c4ad69f3acea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484342
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292200}
[views-ax] Remove SetAccessibleName call from PrivacyScreenToastView
In preparation for the migration and removal of View::SetAccessibleName,
we're cleaning up a few files that were using it in a non-conventional
way.
PrivacyScreenToastView was using SetAccessibleName to cache the
accessible name in the `accessible_name_` member of the View class, so
it could later be retrieved by the GetAccessibleName method when
requested by the WidgetDelegate of the RootView.
While this was technically working, it was not the intended use of
SetAccessibleName, and it was causing test failures in CL:5445832 as
we are trying to migrate away from the `accessible_name_` member
on View.
This CL sets the accessible name directly on a new member of the
PrivacyScreenToastView class and removes the SetAccessibleName call.
In the near future, we will get rid of that new member and instead
notify the RootView directly when the accessible name changes, as part
of the ViewsAX project.
Bug: 325137417
Change-Id: Ia021a36c490802f2f43fd53be1f0a27d3b8e5250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484294
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292199}
Roll V8 from 06664036fd0b to 11f0340b1784 (3 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/06664036fd0b..11f0340b1784
2024-04-24 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.96
2024-04-24 syg@chromium.org Unmark failing test fixed by ICU roll
2024-04-24 adamk@chromium.org Reland "[api] Advance deprecation of API not called by Chromium"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I131f5465a149616247acb787054bcca21273cfce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486073
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292198}
Revert "[Grid] Reuse a subgrid's MinMaxSizes cache whenever possible"
This reverts commit d8e813e56af22ac513bd3a4841948afaa650530f.
Reason for revert: Regression in live site - see https://issues.chromium.org/issues/336358908
Original change's description:
> [Grid] Reuse a subgrid's MinMaxSizes cache whenever possible
>
> 1. Removing the concept of only reusing the `MinMaxSizes` cache of a
> subgrid within the same step of the grid sizing algorithm in favor
> of reusing it in the second pass or within different runs of the
> `ComputeMinMaxSizes` and `Layout` methods if possible.
>
> 2. To determine whether we can reuse the cache or not we rely on the new
> `IsSubgridMinMaxSizesCacheDirty` flag in `LayoutObject`, but this
> change introduces more logic that determines if the cache must be
> invalidated depending on whether a subgrid's subgridded tracks
> changed between calls to compute its intrinsic sizes.
>
> 3. This change shouldn't have any behavioral impact.
>
> Significant perf deltas:
> - nested-subgrid
> avg 260.401 runs/s -> 286.556 runs/s (10% better)
>
> Bug: 1505606
> Change-Id: Id2cee4d5b412867f3002ae2f532fa7ebe1857d9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230717
> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
> Reviewed-by: Alison Maher <almaher@microsoft.com>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1266107}
Bug: 1505606,336358908
Change-Id: I209fe909dc9b70c0b05ec382ff130b0c905176aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484497
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292197}